chore: Bump Neo4j version from 3.3 to 3.5 (#953)

* chore: Bump Neo4j version from 3.3 to 3.5
Signed-off-by: Madison Swain-Bowden <madison.bowden@ookla.com>

* Fix neo4j config, include Neo4j upgrade in ECS compose script
Signed-off-by: Madison Swain-Bowden <madison.bowden@ookla.com>

docker-amundsen-local.yml

 version: '3'
 services:
   neo4j:
-      image: neo4j:3.3.0
+      image: neo4j:3.5.26
       container_name: neo4j_amundsen
       environment:
         - NEO4J_AUTH=neo4j/test
@@ -13,8 +13,8 @@ services:
           - 7474:7474
           - 7687:7687
       volumes:
-          - ./example/docker/neo4j/conf:/conf
-          - ./.local/neo4j/data:/neo4j/data
+          - ./example/docker/neo4j/conf:/var/lib/neo4j/conf
+          - ./.local/neo4j/data:/data
       networks:
         - amundsennet
   elasticsearch:

docker-amundsen.yml

 version: '3'
 services:
   neo4j:
-      image: neo4j:3.3.0
+      image: neo4j:3.5.26
       container_name: neo4j_amundsen
       environment:
         - NEO4J_AUTH=neo4j/test
@@ -13,10 +13,10 @@ services:
           - 7474:7474
           - 7687:7687
       volumes:
-          - ./example/docker/neo4j/conf:/conf
-          - ./example/docker/neo4j/plugins:/plugins
+          - ./example/docker/neo4j/conf:/var/lib/neo4j/conf
+          - ./example/docker/neo4j/plugins:/var/lib/neo4j/plugins
           - ./example/backup:/backup
-          - neo4j_data:/neo4j/data
+          - neo4j_data:/data
       networks:
         - amundsennet
   elasticsearch:

docs/installation-aws-ecs/docker-ecs-amundsen.yml

 version: '3'
 services:
   neo4j:
-      image: neo4j:3.3.0
+      image: neo4j:3.5.26
       container_name: neo4j_amundsen
       environment:
         - NEO4J_AUTH=neo4j/test
-        # These dont seem to be working though!
-        - NEO4J_dbms.active_database=amundsen.db
-        - NEO4J_dbms.directories.data=/neo4j/data
-        - NEO4J_dbms.directories.logs=/var/log/neo4j
-        - NEO4J_dbms.directories.import=/var/lib/neo4j/import
-        - NEO4J_dbms.security.auth_enabled=false
-        - NEO4J_dbms.connectors.default_listen_address=0.0.0.0
+        - NEO4J_dbms_active__database=amundsen.db
+        - NEO4J_dbms_directories_data=/data
+        - NEO4J_dbms_directories_logs=/logs
+        - NEO4J_dbms_directories_import=/var/lib/neo4j/import
+        - NEO4J_dbms_security_auth__enabled=false
+        - NEO4J_dbms_connectors_default__listen__address=0.0.0.0
       ulimits:
         nofile:
           soft: 40000

example/docker/neo4j/conf/neo4j.conf

@@ -9,10 +9,10 @@
 dbms.active_database=amundsen.db
 
 # Paths of directories in the installation.
-dbms.directories.data=/neo4j/data
+dbms.directories.data=/data
+dbms.directories.logs=/logs
 #dbms.directories.plugins=/var/lib/neo4j/plugins
 #dbms.directories.certificates=/var/lib/neo4j/certificates
-dbms.directories.logs=/var/log/neo4j
 #dbms.directories.lib=/usr/share/neo4j/lib
 #dbms.directories.run=/var/run/neo4j
 
@@ -228,13 +228,6 @@ dbms.connector.https.enabled=true
 # Retention policy for transaction logs needed to perform recovery and backups.
 dbms.tx_log.rotation.retention_policy=1 days
 
-# Enable a remote shell server which Neo4j Shell clients can log in to.
-dbms.shell.enabled=true
-# The network interface IP the shell will listen on (use 0.0.0.0 for all interfaces).
-#dbms.shell.host=127.0.0.1
-# The port the shell will listen on, default is 1337.
-#dbms.shell.port=1337
-
 # Only allow read operations from this Neo4j instance. This mode still requires
 # write access to the directory for lock purposes.
 #dbms.read_only=false