Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
A
AmendsenProject
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Shaik Janipasha
AmendsenProject
Commits
e54fb8f7
Unverified
Commit
e54fb8f7
authored
Aug 19, 2020
by
Marcos Iglesias
Committed by
GitHub
Aug 19, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixes error on TableDetail on Dev (#597)
Signed-off-by:
Marcos Iglesias
<
miglesiasvalle@lyft.com
>
parent
7b221c28
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
8 deletions
+6
-8
index.tsx
.../components/TableDetail/ResourceReportsDropdown/index.tsx
+4
-1
constants.ts
...application/static/js/components/TableDetail/constants.ts
+0
-1
index.tsx
...en_application/static/js/components/TableDetail/index.tsx
+2
-6
No files found.
amundsen_application/static/js/components/TableDetail/ResourceReportsDropdown/index.tsx
View file @
e54fb8f7
...
@@ -10,7 +10,10 @@ export interface ResourceReportProps {
...
@@ -10,7 +10,10 @@ export interface ResourceReportProps {
const
TableReportsDropdown
:
React
.
FC
<
ResourceReportProps
>
=
({
const
TableReportsDropdown
:
React
.
FC
<
ResourceReportProps
>
=
({
resourceReports
,
resourceReports
,
}:
ResourceReportProps
)
=>
{
}:
ResourceReportProps
)
=>
{
if
(
resourceReports
===
null
||
resourceReports
.
length
<
1
)
return
null
;
if
(
!
resourceReports
||
resourceReports
.
length
<
1
)
{
return
null
;
}
return
(
return
(
<
Dropdown
id=
"user-dropdown"
>
<
Dropdown
id=
"user-dropdown"
>
<
Dropdown
.
Toggle
className=
"btn btn-default btn-lg"
>
<
Dropdown
.
Toggle
className=
"btn btn-default btn-lg"
>
...
...
amundsen_application/static/js/components/TableDetail/constants.ts
View file @
e54fb8f7
export
const
PROGRMMATIC_DESC_HEADER
=
'Read-only information, auto-generated'
;
export
const
ERROR_MESSAGE
=
'Something went wrong...'
;
export
const
ERROR_MESSAGE
=
'Something went wrong...'
;
export
const
EDIT_DESC_TEXT
=
'Click to edit description in'
;
export
const
EDIT_DESC_TEXT
=
'Click to edit description in'
;
amundsen_application/static/js/components/TableDetail/index.tsx
View file @
e54fb8f7
...
@@ -50,6 +50,7 @@ import {
...
@@ -50,6 +50,7 @@ import {
}
from
'interfaces'
;
}
from
'interfaces'
;
import
EditableSection
from
'components/common/EditableSection'
;
import
EditableSection
from
'components/common/EditableSection'
;
import
TableReportsDropdown
from
'components/TableDetail/ResourceReportsDropdown'
;
import
{
formatDateTimeShort
}
from
'utils/dateUtils'
;
import
{
formatDateTimeShort
}
from
'utils/dateUtils'
;
import
{
getLoggingParams
}
from
'utils/logUtils'
;
import
{
getLoggingParams
}
from
'utils/logUtils'
;
...
@@ -57,14 +58,9 @@ import { getLoggingParams } from 'utils/logUtils';
...
@@ -57,14 +58,9 @@ import { getLoggingParams } from 'utils/logUtils';
import
RequestDescriptionText
from
'./RequestDescriptionText'
;
import
RequestDescriptionText
from
'./RequestDescriptionText'
;
import
RequestMetadataForm
from
'./RequestMetadataForm'
;
import
RequestMetadataForm
from
'./RequestMetadataForm'
;
import
{
import
{
ERROR_MESSAGE
,
EDIT_DESC_TEXT
}
from
'./constants'
;
PROGRMMATIC_DESC_HEADER
,
ERROR_MESSAGE
,
EDIT_DESC_TEXT
,
}
from
'./constants'
;
import
'./styles.scss'
;
import
'./styles.scss'
;
import
TableReportsDropdown
from
'components/TableDetail/ResourceReportsDropdown'
;
const
SERVER_ERROR_CODE
=
500
;
const
SERVER_ERROR_CODE
=
500
;
const
DASHBOARDS_PER_PAGE
=
10
;
const
DASHBOARDS_PER_PAGE
=
10
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment