Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in
E
ecommerce-maven
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Ascend
  • ecommerce-maven
  • Merge Requests
  • !2

Merged
Opened May 10, 2021 by Shaphen Pangburn@spangburn
  • Report abuse
Report abuse

Product page users can see products and associated promotion info for each item in main product page

Note: the logic for matching a promotion to a particular product is currently inefficient (currently O(n^2)) but works for our scope. Feel free to refactor that logic if you would like to make it more efficient for the sake of best practice.

Currently the Product Market Page can:

  • Display all products available from the Inventory backend
  • Display promotional data for each product that has an associated Promotion connected by productSku
  • Show more information when clicking on the top half of the product's display box. Upon which will open a modal with more details such as mock shipping data, brand, and sku number

Buttons to Add to Cart and enter a quantity desired are displayed but not operable. This will be function after completing AFP-48

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b product-page-users-can-see-products-and-associated-promotion-info-for-each-item-in-main-product-page origin/product-page-users-can-see-products-and-associated-promotion-info-for-each-item-in-main-product-page

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff product-page-users-can-see-products-and-associated-promotion-info-for-each-item-in-main-product-page

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 0
  • Commits 23
  • Changes 211
Christopher Cottier
Assignee
Christopher Cottier @ccottier
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: ascend/ecommerce-maven!2

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.