made update route more efficient

src/main/java/com/nisum/employeeservice/controller/EmployeeController.java

@@ -41,15 +41,17 @@ public class EmployeeController {
   }
 
   // Update a particular employee
-  @PutMapping("/employees/update/{id}")
-  public ResponseEntity<Employee> updateEmployeeById(@PathVariable(value = "id") Long employeeId, @RequestBody Employee employeeNew) throws ResourceNotFoundException {
-    Employee employeeOld = employeeService.getEmployeeById(employeeId)
-            .orElseThrow(() -> new ResourceNotFoundException("Employee by Id Not Found" + employeeId));
+  @PutMapping("/employees/update/")
+  public ResponseEntity<Employee> updateEmployeeById(@RequestBody Employee employeeNew) throws ResourceNotFoundException {
+    Employee employee = employeeService.getEmployeeById(employeeNew.getId())
+            .orElseThrow(() -> new ResourceNotFoundException("Employee by Id Not Found" + employeeNew.getId()));
+
+    employee.setLastName(employeeNew.getLastName());
+    employee.setFirstName(employeeNew.getFirstName());
 
-    employeeService.deleteEmployeeById(employeeOld.getId());
-    employeeService.addEmployee(employeeNew);
+    employeeService.updateEmployee(employee);
 
-    return ResponseEntity.ok().body(employeeNew);
+    return ResponseEntity.ok().body(employee);
   }
 
 

src/main/java/com/nisum/employeeservice/service/EmployeeService.java

@@ -15,7 +15,6 @@ public class EmployeeService {
 
 
   public List<Employee> findAllEmployees() {
-    /*some business*/
     return employeeRepository.findAll();
   }
 
@@ -23,17 +22,15 @@ public class EmployeeService {
     return employeeRepository.save(employee);
   }
 
-//  public void updateEmployee(Employee employee) {
-//    employeeRepository.
-//
-//  }
-
   public Optional<Employee> getEmployeeById(Long employeeId) {
     return employeeRepository.findById(employeeId);
   }
 
-
   public void deleteEmployeeById(Long employeeId) {
     employeeRepository.deleteById(employeeId);
   }
+
+  public void updateEmployee(Employee employee) {
+    employeeRepository.save(employee);
+  }
 }