Removed the hard coded values of employee roles in employeeservice

src/main/java/com/nisum/myteam/service/impl/EmployeeService.java

@@ -8,6 +8,7 @@ import com.nisum.myteam.repository.EmployeeRepo;
 import com.nisum.myteam.service.*;
 import com.nisum.myteam.utils.MyTeamUtils;
 import com.nisum.myteam.utils.constants.ApplicationRole;
+import com.nisum.myteam.utils.constants.RoleConstant;
 import lombok.extern.slf4j.Slf4j;
 import org.apache.commons.lang.StringUtils;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -173,17 +174,29 @@ public class EmployeeService implements IEmployeeService {
         return employee;
     }
 
+    @Override
+    public List<Employee> getAllEmployees() {
+        return employeeRepo.findAll();
+    }
+
     @Override
     public Employee getEmployeeByEmaillId(String emailId) {
         return employeeRepo.findByEmailId(emailId);
     }
 
+    @Override
+    public List<Employee> getEmployeesByEmpStatusAndShift(String empStatus, String shift) {
+        return employeeRepo.findByEmpStatusAndShiftLikeOrderByEmployeeIdDesc(empStatus, shift);
+    }
+
     public List<Employee> getManagers() throws MyTeamException {
         List<Employee> activeEmpsList = getActiveEmployees();
         List<Employee> managers = activeEmpsList.stream()
-                .filter(e -> ("Director".equalsIgnoreCase(e.getRole())
-                        || "Delivery Manager".equalsIgnoreCase(e.getRole()) || "Manager".equalsIgnoreCase(e.getRole())
-                        || "HR Manager".equalsIgnoreCase(e.getRole()) || "Lead".equalsIgnoreCase(e.getRole())))
+                .filter(employee -> (RoleConstant.DIRECTOR.getRoleName().equalsIgnoreCase(employee.getRole())
+                        || RoleConstant.DELIVERY_MANAGER.getRoleName().equalsIgnoreCase(employee.getRole())
+                        || RoleConstant.MANAGER.getRoleName().equalsIgnoreCase(employee.getRole())
+                        || RoleConstant.HR_MANAGER.getRoleName().equalsIgnoreCase(employee.getRole())
+                        || RoleConstant.LEAD.getRoleName().equalsIgnoreCase(employee.getRole())))
                 .sorted(Comparator.comparing(Employee::getEmployeeName)).collect(Collectors.toList());
         return managers;
     }
@@ -250,7 +263,6 @@ public class EmployeeService implements IEmployeeService {
         return getDeliveryManagerMap(domain.getDeliveryManagers());
     }
 
-
     @Override
     public List<HashMap<String, String>> getDeliveryManagerMap(List deliveryManagerIdsList) {
         List<HashMap<String, String>> employeeList = new ArrayList<>();
@@ -312,15 +324,5 @@ public class EmployeeService implements IEmployeeService {
 
     }
 
-    @Override
-    public List<Employee> getAllEmployees() {
-        return employeeRepo.findAll();
-    }
-
-    @Override
-    public List<Employee> getEmployeesByEmpStatusAndShift(String empStatus, String shift) {
-        return employeeRepo.findByEmpStatusAndShiftLikeOrderByEmployeeIdDesc(empStatus, shift);
-    }
-
 
 }

src/main/java/com/nisum/myteam/utils/constants/RoleConstant.java

+package com.nisum.myteam.utils.constants;
+
+public enum RoleConstant {
+
+
+   DIRECTOR("","Director"),DELIVERY_MANAGER("","Delivery Manager"),
+    MANAGER("","Manager"),HR_MANAGER("","HR Manager"),LEAD("","Lead");
+    private String roleId;
+    private String roleName;
+
+    private RoleConstant(String roleId, String roleName) {
+        this.roleId = roleId;
+        this.roleName = roleName;
+    }
+
+
+    public String getRoleId() {
+        return this.roleId;
+    }
+
+    public String getRoleName() {
+        return this.roleName;
+    }
+}