chore: build(deps): bump flake8 from 3.5.0 to 3.8.4 (#704)

* build(deps): bump flake8 from 3.5.0 to 3.8.4

Bumps [flake8](https://gitlab.com/pycqa/flake8) from 3.5.0 to 3.8.4.
- [Release notes](https://gitlab.com/pycqa/flake8/tags)
- [Commits](https://gitlab.com/pycqa/flake8/compare/3.5.0...3.8.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* lint fixes
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* exception as e lint issue
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* fixed exception flake8 error
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* more lint
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* weird lint
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* weird lint errors deadlock fix
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

* spaces mismatch
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>

amundsen_application/base/base_superset_preview_client.py

@@ -52,5 +52,5 @@ class BaseSupersetPreviewClient(BasePreviewClient):
                 return make_response(payload, response.status_code)
             else:
                 return make_response(jsonify({'preview_data': {}}), HTTPStatus.INTERNAL_SERVER_ERROR)
-        except Exception as e:
+        except Exception:
             return make_response(jsonify({'preview_data': {}}), HTTPStatus.INTERNAL_SERVER_ERROR)

amundsen_application/log/action_log.py

@@ -50,7 +50,7 @@ def action_logging(f: Callable) -> Any:
             metrics['end_epoch_ms'] = get_epoch_millisec()
             try:
                 metrics['output'] = json.dumps(output)
-            except Exception as e:
+            except Exception:
                 metrics['output'] = output
 
             action_log_callback.on_post_execution(ActionLogParams(**metrics))

amundsen_application/wsgi.py

@@ -5,8 +5,7 @@ import os
 from amundsen_application import create_app
 
 application = create_app(
-    config_module_class=os.getenv('FRONTEND_SVC_CONFIG_MODULE_CLASS') or
-    'amundsen_application.config.LocalConfig')
+    config_module_class=os.getenv('FRONTEND_SVC_CONFIG_MODULE_CLASS') or 'amundsen_application.config.LocalConfig')
 
 if __name__ == '__main__':
     application.run(host='0.0.0.0')

requirements.txt

 # The modular source code checker: pep8, pyflakes and co
 # License: MIT
 # Upstream url: http://bitbucket.org/tarek/flake8
-flake8==3.5.0
+flake8==3.8.4
 
 # A flake8 plugin that helps you write tidier imports.
 # License: ISCL

setup.py

@@ -15,7 +15,7 @@ def is_npm_installed() -> bool:
     try:
         subprocess.check_call(['npm --version'], shell=True)
         return True
-    except Exception as e:
+    except subprocess.CalledProcessError:
         return False
 
 

tests/unit/issue_tracker_clients/test_jira_client.py

@@ -179,6 +179,5 @@ class JiraClientTest(unittest.TestCase):
                 'name': 'Bug',
             }, labels=mock_labels,
                 summary='title',
-                description='desc' + ' \n Reported By: test@email.com' +
-                            ' \n Table Key: ' + 'key [PLEASE DO NOT REMOVE]',
+                description='desc \n Reported By: test@email.com \n Table Key: key [PLEASE DO NOT REMOVE]',
                 reporter={'name': 'test'}))