Fixes issues with no-unused-expressions ESLint rule (#538)

amundsen_application/static/js/components/HomePage/index.spec.tsx

@@ -65,7 +65,7 @@ describe('HomePage', () => {
     it('calls searchReset', () => {
       const searchResetSpy = jest.spyOn(props, 'searchReset');
       wrapper.instance().componentDidMount();
-      expect(searchResetSpy).toHaveBeenCalled;
+      expect(searchResetSpy).toHaveBeenCalled();
     });
   });
 });

amundsen_application/static/js/components/Tags/TagInput/index.tsx

@@ -179,9 +179,12 @@ class TagInput extends React.Component<TagInputProps, TagInputState> {
 
   toggleTag = (event, tagName) => {
     const element = event.currentTarget;
-    element.classList.contains('selected')
-      ? element.classList.remove('selected')
-      : element.classList.add('selected');
+
+    if (element.classList.contains('selected')) {
+      element.classList.remove('selected');
+    } else {
+      element.classList.add('selected');
+    }
 
     if (!this.batchEditSet.hasOwnProperty(tagName)) {
       this.batchEditSet[tagName] = BatchEditState.PUT;
@@ -240,11 +243,15 @@ class TagInput extends React.Component<TagInputProps, TagInputState> {
   }
 
   startEditing = () => {
-    this.props.setEditMode && this.props.setEditMode(true);
+    if (this.props.setEditMode) {
+      this.props.setEditMode(true);
+    }
   };
 
   stopEditing = () => {
-    this.props.setEditMode && this.props.setEditMode(false);
+    if (this.props.setEditMode) {
+      this.props.setEditMode(false);
+    }
   };
 
   render() {

amundsen_application/static/package.json

@@ -280,7 +280,6 @@
       "@typescript-eslint/dot-notation": "warn",
       "@typescript-eslint/lines-between-class-members": "warn",
       "@typescript-eslint/naming-convention": "warn",
-      "@typescript-eslint/no-unused-expressions": "warn",
       "@typescript-eslint/no-unused-vars": "warn",
       "@typescript-eslint/member-delimiter-style": [
         "off",