Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
A
AmendsenProject
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Shaik Janipasha
AmendsenProject
Commits
9b8b0a93
Unverified
Commit
9b8b0a93
authored
Apr 26, 2019
by
Daniel
Committed by
GitHub
Apr 26, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Added a 'is_view' and 'Table View' indicator on the table details page (#106)
parent
f2641319
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
25 additions
and
9 deletions
+25
-9
v0.py
amundsen_application/api/metadata/v0.py
+1
-0
index.tsx
...en_application/static/js/components/TableDetail/index.tsx
+16
-7
types.ts
...sen_application/static/js/components/TableDetail/types.ts
+1
-0
styles.scss
..._application/static/js/components/common/Flag/styles.scss
+3
-2
reducer.ts
...dsen_application/static/js/ducks/tableMetadata/reducer.ts
+1
-0
globalState.ts
amundsen_application/static/js/fixtures/globalState.ts
+1
-0
test_v0.py
tests/unit/api/metadata/test_v0.py
+2
-0
No files found.
amundsen_application/api/metadata/v0.py
View file @
9b8b0a93
...
...
@@ -180,6 +180,7 @@ def _get_table_metadata(*, table_key: str, index: int, source: str) -> Dict[str,
'cluster'
,
'database'
,
'owners'
,
'is_view'
,
'schema'
,
'table_description'
,
'table_name'
,
...
...
amundsen_application/static/js/components/TableDetail/index.tsx
View file @
9b8b0a93
...
...
@@ -13,6 +13,7 @@ import AppConfig from 'config/config';
import
AvatarLabel
from
'components/common/AvatarLabel'
;
import
Breadcrumb
from
'components/common/Breadcrumb'
;
import
EntityCard
from
'components/common/EntityCard'
;
import
Flag
from
"components/common/Flag"
;
import
LoadingSpinner
from
'components/common/LoadingSpinner'
;
import
ScrollTracker
from
"components/common/ScrollTracker"
;
import
TagInput
from
'components/Tags/TagInput'
;
...
...
@@ -68,6 +69,7 @@ export class TableDetail extends React.Component<TableDetailProps & RouteCompone
columns
:
[],
database
:
''
,
is_editable
:
false
,
is_view
:
false
,
schema
:
''
,
table_name
:
''
,
table_description
:
''
,
...
...
@@ -330,13 +332,20 @@ export class TableDetail extends React.Component<TableDetailProps & RouteCompone
<
Breadcrumb
path=
'/'
text=
'Search Results'
/>
<
div
className=
"row"
>
<
div
className=
"detail-header col-xs-12 col-md-7 col-lg-8"
>
<
div
className=
"title"
>
{
`${data.schema}.${data.table_name}`
}
</
div
>
<
WatermarkLabel
watermarks=
{
data
.
watermarks
}
/>
<
TableDescEditableText
maxLength=
{
750
}
value=
{
data
.
table_description
}
editable=
{
data
.
is_editable
}
/>
<
div
className=
"title"
>
{
`${data.schema}.${data.table_name}`
}
</
div
>
{
data
.
is_view
&&
<
Flag
text=
"Table View"
labelStyle=
"primary"
/>
}
{
!
data
.
is_view
&&
<
WatermarkLabel
watermarks=
{
data
.
watermarks
}
/>
}
<
TableDescEditableText
maxLength=
{
750
}
value=
{
data
.
table_description
}
editable=
{
data
.
is_editable
}
/>
</
div
>
<
div
className=
"col-xs-12 col-md-5 float-md-right col-lg-4"
>
<
EntityCard
sections=
{
this
.
createEntityCardSections
()
}
/>
...
...
amundsen_application/static/js/components/TableDetail/types.ts
View file @
9b8b0a93
...
...
@@ -75,6 +75,7 @@ export interface TableMetadata {
columns
:
TableColumn
[];
database
:
string
;
is_editable
:
boolean
;
is_view
:
boolean
;
schema
:
string
;
table_name
:
string
;
table_description
:
string
;
...
...
amundsen_application/static/js/components/common/Flag/styles.scss
View file @
9b8b0a93
@import
'variables'
;
.flag
{
margin-right
:
4px
;
margin-left
:
4px
;
display
:
inline-block
;
margin
:
4px
4px
4px
0
;
font-size
:
14px
;
}
amundsen_application/static/js/ducks/tableMetadata/reducer.ts
View file @
9b8b0a93
...
...
@@ -103,6 +103,7 @@ const initialTableDataState: TableMetadata = {
columns
:
[],
database
:
''
,
is_editable
:
false
,
is_view
:
false
,
schema
:
''
,
table_name
:
''
,
table_description
:
''
,
...
...
amundsen_application/static/js/fixtures/globalState.ts
View file @
9b8b0a93
...
...
@@ -49,6 +49,7 @@ const globalState: GlobalState = {
columns
:
[],
database
:
''
,
is_editable
:
false
,
is_view
:
false
,
schema
:
''
,
table_name
:
''
,
table_description
:
''
,
...
...
tests/unit/api/metadata/test_v0.py
View file @
9b8b0a93
...
...
@@ -46,6 +46,7 @@ class MetadataTest(unittest.TestCase):
{
'reader'
:
{
'email'
:
'test@test.com'
,
'first_name'
:
None
,
'last_name'
:
None
},
'read_count'
:
100
}
],
'owners'
:
[],
'is_view'
:
False
,
'columns'
:
[
{
'name'
:
'column_1'
,
...
...
@@ -94,6 +95,7 @@ class MetadataTest(unittest.TestCase):
'value'
:
'01-30-2019'
},
'owners'
:
[],
'is_view'
:
False
,
'columns'
:
[
{
'name'
:
'column_1'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment