Unverified Commit 9b8b0a93 authored by Daniel's avatar Daniel Committed by GitHub

Added a 'is_view' and 'Table View' indicator on the table details page (#106)

parent f2641319
......@@ -180,6 +180,7 @@ def _get_table_metadata(*, table_key: str, index: int, source: str) -> Dict[str,
'cluster',
'database',
'owners',
'is_view',
'schema',
'table_description',
'table_name',
......
......@@ -13,6 +13,7 @@ import AppConfig from 'config/config';
import AvatarLabel from 'components/common/AvatarLabel';
import Breadcrumb from 'components/common/Breadcrumb';
import EntityCard from 'components/common/EntityCard';
import Flag from "components/common/Flag";
import LoadingSpinner from 'components/common/LoadingSpinner';
import ScrollTracker from "components/common/ScrollTracker";
import TagInput from 'components/Tags/TagInput';
......@@ -68,6 +69,7 @@ export class TableDetail extends React.Component<TableDetailProps & RouteCompone
columns: [],
database: '',
is_editable: false,
is_view: false,
schema: '',
table_name: '',
table_description: '',
......@@ -330,13 +332,20 @@ export class TableDetail extends React.Component<TableDetailProps & RouteCompone
<Breadcrumb path='/' text='Search Results'/>
<div className="row">
<div className="detail-header col-xs-12 col-md-7 col-lg-8">
<div className="title">{ `${data.schema}.${data.table_name}` }</div>
<WatermarkLabel watermarks={ data.watermarks }/>
<TableDescEditableText
maxLength={ 750 }
value={ data.table_description }
editable={ data.is_editable }
/>
<div className="title">
{ `${data.schema}.${data.table_name}` }
</div>
{
data.is_view && <Flag text="Table View" labelStyle="primary" />
}
{
!data.is_view && <WatermarkLabel watermarks={ data.watermarks }/>
}
<TableDescEditableText
maxLength={ 750 }
value={ data.table_description }
editable={ data.is_editable }
/>
</div>
<div className="col-xs-12 col-md-5 float-md-right col-lg-4">
<EntityCard sections={ this.createEntityCardSections() }/>
......
......@@ -75,6 +75,7 @@ export interface TableMetadata {
columns: TableColumn[];
database: string;
is_editable: boolean;
is_view: boolean;
schema: string;
table_name: string;
table_description: string;
......
@import 'variables';
.flag {
margin-right: 4px;
margin-left: 4px;
display: inline-block;
margin: 4px 4px 4px 0;
font-size: 14px;
}
......@@ -103,6 +103,7 @@ const initialTableDataState: TableMetadata = {
columns: [],
database: '',
is_editable: false,
is_view: false,
schema: '',
table_name: '',
table_description: '',
......
......@@ -49,6 +49,7 @@ const globalState: GlobalState = {
columns: [],
database: '',
is_editable: false,
is_view: false,
schema: '',
table_name: '',
table_description: '',
......
......@@ -46,6 +46,7 @@ class MetadataTest(unittest.TestCase):
{'reader': {'email': 'test@test.com', 'first_name': None, 'last_name': None}, 'read_count': 100}
],
'owners': [],
'is_view': False,
'columns': [
{
'name': 'column_1',
......@@ -94,6 +95,7 @@ class MetadataTest(unittest.TestCase):
'value': '01-30-2019'
},
'owners': [],
'is_view': False,
'columns': [
{
'name': 'column_1',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment