Unverified Commit a041ed85 authored by Wonyeong Choi's avatar Wonyeong Choi Committed by GitHub

chore: Update derpecated functions: assertEquals, assertDictContainsSubset (#752)

Signed-off-by: 's avatarWonyeong Choi <ciwnyg0815@gmail.com>
parent 0b5325f6
...@@ -133,7 +133,7 @@ class MailTest(unittest.TestCase): ...@@ -133,7 +133,7 @@ class MailTest(unittest.TestCase):
'sender': test_sender, 'sender': test_sender,
'options': test_options, 'options': test_options,
}) })
self.assertEquals(response.status_code, HTTPStatus.BAD_REQUEST) self.assertEqual(response.status_code, HTTPStatus.BAD_REQUEST)
self.assertFalse(send_notification_mock.called) self.assertFalse(send_notification_mock.called)
@unittest.mock.patch('amundsen_application.api.mail.v0.send_notification') @unittest.mock.patch('amundsen_application.api.mail.v0.send_notification')
...@@ -147,5 +147,5 @@ class MailTest(unittest.TestCase): ...@@ -147,5 +147,5 @@ class MailTest(unittest.TestCase):
# generates error # generates error
response = test.post('/api/mail/v0/notification', json=None) response = test.post('/api/mail/v0/notification', json=None)
self.assertEquals(response.status_code, HTTPStatus.INTERNAL_SERVER_ERROR) self.assertEqual(response.status_code, HTTPStatus.INTERNAL_SERVER_ERROR)
self.assertFalse(send_notification_mock.called) self.assertFalse(send_notification_mock.called)
...@@ -754,7 +754,7 @@ class MetadataTest(unittest.TestCase): ...@@ -754,7 +754,7 @@ class MetadataTest(unittest.TestCase):
'tag': 'tag_5' 'tag': 'tag_5'
} }
) )
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
@responses.activate @responses.activate
def test_update_table_tags_delete(self) -> None: def test_update_table_tags_delete(self) -> None:
...@@ -773,7 +773,7 @@ class MetadataTest(unittest.TestCase): ...@@ -773,7 +773,7 @@ class MetadataTest(unittest.TestCase):
'tag': 'tag_5' 'tag': 'tag_5'
} }
) )
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
@responses.activate @responses.activate
def test_update_dashboard_tags_put(self) -> None: def test_update_dashboard_tags_put(self) -> None:
...@@ -792,7 +792,7 @@ class MetadataTest(unittest.TestCase): ...@@ -792,7 +792,7 @@ class MetadataTest(unittest.TestCase):
'tag': 'test_tag' 'tag': 'test_tag'
} }
) )
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
@responses.activate @responses.activate
def test_update_dashboard_tags_delete(self) -> None: def test_update_dashboard_tags_delete(self) -> None:
...@@ -811,7 +811,7 @@ class MetadataTest(unittest.TestCase): ...@@ -811,7 +811,7 @@ class MetadataTest(unittest.TestCase):
'tag': 'test_tag' 'tag': 'test_tag'
} }
) )
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
@responses.activate @responses.activate
def test_get_user_failure(self) -> None: def test_get_user_failure(self) -> None:
...@@ -823,7 +823,7 @@ class MetadataTest(unittest.TestCase): ...@@ -823,7 +823,7 @@ class MetadataTest(unittest.TestCase):
with local_app.test_client() as test: with local_app.test_client() as test:
response = test.get('/api/metadata/v0/user') response = test.get('/api/metadata/v0/user')
self.assertEquals(response.status_code, HTTPStatus.INTERNAL_SERVER_ERROR) self.assertEqual(response.status_code, HTTPStatus.INTERNAL_SERVER_ERROR)
@responses.activate @responses.activate
def test_get_user_success(self) -> None: def test_get_user_success(self) -> None:
...@@ -836,8 +836,8 @@ class MetadataTest(unittest.TestCase): ...@@ -836,8 +836,8 @@ class MetadataTest(unittest.TestCase):
with local_app.test_client() as test: with local_app.test_client() as test:
response = test.get('/api/metadata/v0/user', query_string=dict(user_id='testuser')) response = test.get('/api/metadata/v0/user', query_string=dict(user_id='testuser'))
data = json.loads(response.data) data = json.loads(response.data)
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertDictContainsSubset(self.expected_parsed_user, data.get('user')) self.assertEqual(dict(data.get('user'), **self.expected_parsed_user), data.get('user'))
@responses.activate @responses.activate
def test_get_bookmark(self) -> None: def test_get_bookmark(self) -> None:
...@@ -850,7 +850,7 @@ class MetadataTest(unittest.TestCase): ...@@ -850,7 +850,7 @@ class MetadataTest(unittest.TestCase):
with local_app.test_client() as test: with local_app.test_client() as test:
response = test.get('/api/metadata/v0/user/bookmark') response = test.get('/api/metadata/v0/user/bookmark')
data = json.loads(response.data) data = json.loads(response.data)
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertCountEqual(data.get('bookmarks'), self.expected_parsed_user_resources) self.assertCountEqual(data.get('bookmarks'), self.expected_parsed_user_resources)
@responses.activate @responses.activate
...@@ -882,7 +882,7 @@ class MetadataTest(unittest.TestCase): ...@@ -882,7 +882,7 @@ class MetadataTest(unittest.TestCase):
with local_app.test_client() as test: with local_app.test_client() as test:
response = test.get('/api/metadata/v0/user/bookmark', query_string=dict(user_id=specified_user)) response = test.get('/api/metadata/v0/user/bookmark', query_string=dict(user_id=specified_user))
data = json.loads(response.data) data = json.loads(response.data)
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertCountEqual(data.get('bookmarks'), self.expected_parsed_user_resources) self.assertCountEqual(data.get('bookmarks'), self.expected_parsed_user_resources)
@responses.activate @responses.activate
...@@ -907,7 +907,7 @@ class MetadataTest(unittest.TestCase): ...@@ -907,7 +907,7 @@ class MetadataTest(unittest.TestCase):
'key': key, 'key': key,
}) })
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
@responses.activate @responses.activate
def test_delete_bookmark(self) -> None: def test_delete_bookmark(self) -> None:
...@@ -931,7 +931,7 @@ class MetadataTest(unittest.TestCase): ...@@ -931,7 +931,7 @@ class MetadataTest(unittest.TestCase):
'key': key, 'key': key,
}) })
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
@responses.activate @responses.activate
def test_get_user_read(self) -> None: def test_get_user_read(self) -> None:
...@@ -945,7 +945,7 @@ class MetadataTest(unittest.TestCase): ...@@ -945,7 +945,7 @@ class MetadataTest(unittest.TestCase):
with local_app.test_client() as test: with local_app.test_client() as test:
response = test.get('/api/metadata/v0/user/read', query_string=dict(user_id=test_user)) response = test.get('/api/metadata/v0/user/read', query_string=dict(user_id=test_user))
data = json.loads(response.data) data = json.loads(response.data)
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertCountEqual(data.get('read'), self.expected_parsed_user_resources.get('table')) self.assertCountEqual(data.get('read'), self.expected_parsed_user_resources.get('table'))
@responses.activate @responses.activate
...@@ -960,7 +960,7 @@ class MetadataTest(unittest.TestCase): ...@@ -960,7 +960,7 @@ class MetadataTest(unittest.TestCase):
with local_app.test_client() as test: with local_app.test_client() as test:
response = test.get('/api/metadata/v0/user/own', query_string=dict(user_id=test_user)) response = test.get('/api/metadata/v0/user/own', query_string=dict(user_id=test_user))
data = json.loads(response.data) data = json.loads(response.data)
self.assertEquals(response.status_code, HTTPStatus.OK) self.assertEqual(response.status_code, HTTPStatus.OK)
self.assertCountEqual(data.get('own'), self.expected_parsed_user_resources) self.assertCountEqual(data.get('own'), self.expected_parsed_user_resources)
@responses.activate @responses.activate
......
...@@ -35,7 +35,7 @@ class ActionLogTest(unittest.TestCase): ...@@ -35,7 +35,7 @@ class ActionLogTest(unittest.TestCase):
'user': getpass.getuser()} 'user': getpass.getuser()}
for k, v in expected.items(): for k, v in expected.items():
self.assertEquals(v, metrics.get(k)) self.assertEqual(v, metrics.get(k))
self.assertTrue(metrics.get('start_epoch_ms') <= get_epoch_millisec()) # type: ignore self.assertTrue(metrics.get('start_epoch_ms') <= get_epoch_millisec()) # type: ignore
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment