Add mypy coverage to test files and cleanup (#369)

.travis.yml

@@ -6,7 +6,7 @@ matrix:
     env:
     - IS_DEPLOYABLE=true
     install:
-    - pip3 install -r requirements3.txt
+    - pip3 install -r requirements.txt
     - pip3 install codecov
     script:
     - make test

Makefile

@@ -18,7 +18,7 @@ lint:
 
 .PHONY: mypy
 mypy:
-	mypy --ignore-missing-imports --follow-imports=skip --strict-optional --warn-no-return amundsen_application
+	mypy --ignore-missing-imports --follow-imports=skip --strict-optional --warn-no-return .
 
 .PHONY: test
 test: test_unit lint mypy

docs/installation.md

@@ -16,7 +16,7 @@ $ cd ../../
 # Install python resources
 $ python3 -m venv venv
 $ source venv/bin/activate
-$ pip3 install -r requirements3.txt
+$ pip3 install -r requirements.txt
 $ python3 setup.py install
 
 # Start server

public.Dockerfile

@@ -12,8 +12,8 @@ FROM python:3.7-slim as base
 WORKDIR /app
 RUN pip3 install gunicorn
 
-COPY requirements3.txt /app/requirements3.txt
-RUN pip3 install -r requirements3.txt
+COPY requirements.txt /app/requirements.txt
+RUN pip3 install -r requirements.txt
 
 COPY --from=node-stage /app /app
 COPY . /app

setup.cfg

@@ -9,7 +9,7 @@ ignore = NONE
 max-line-length = 120
 
 [tool:pytest]
-addopts = --cov=amundsen_application --cov-fail-under=70 --cov-report=term-missing:skip-covered --cov-report=xml --cov-report=html -vvv
+addopts = --cov=amundsen_application --cov-fail-under=75 --cov-report=term-missing:skip-covered --cov-report=xml --cov-report=html -vvv
 
 [coverage:run]
 branch = True

setup.py

@@ -30,7 +30,7 @@ def build_js() -> None:
 
 build_js()
 
-requirements_path = os.path.join(os.path.dirname(os.path.realpath(__file__)), 'requirements3.txt')
+requirements_path = os.path.join(os.path.dirname(os.path.realpath(__file__)), 'requirements.txt')
 with open(requirements_path) as requirements_file:
     requirements = requirements_file.readlines()
 

tests/unit/models/test_user.py

@@ -7,7 +7,7 @@ app = flask.Flask(__name__)
 app.config.from_object('amundsen_application.config.LocalConfig')
 
 
-def mock_get_profile_url(app):
+def mock_get_profile_url(app: str) -> str:
     return 'testUrl'