Fixed empty search bar to go back to home (#211)

* fixed empty search bar issue

* fixed whitespace bugs + handle 400s better

* fixed test issue

* fixed issue with reducer, cleaned up formValid

* updated tests

* removed fixes

amundsen_application/static/js/components/SearchPage/SearchBar/index.tsx

@@ -58,16 +58,18 @@ export class SearchBar extends React.Component<SearchBarProps, SearchBarState> {
   };
 
   handleValueSubmit = (event: React.FormEvent<HTMLFormElement>) : void => {
+    const searchTerm = this.state.searchTerm.trim();
     event.preventDefault();
-    if (this.isFormValid()) {
-      const pathName = `/search?searchTerm=${this.state.searchTerm}&selectedTab=table&pageIndex=0`;
+    if (this.isFormValid(searchTerm)) {
+      let pathName = '/';
+      if (searchTerm !== '') {
+        pathName = `/search?searchTerm=${searchTerm}`;
+      }
       this.props.history.push(pathName);    
     }
   };
 
-  isFormValid = () : boolean => {
-    const searchTerm = this.state.searchTerm;
-
+  isFormValid = (searchTerm: string) : boolean => {
     const hasAtMostOneCategory = searchTerm.split(':').length <= 2;
     if (!hasAtMostOneCategory) {
       this.setState({

amundsen_application/static/js/components/SearchPage/SearchBar/tests/index.spec.tsx

@@ -100,10 +100,17 @@ describe('SearchBar', () => {
       expect(submitMockEvent.preventDefault).toHaveBeenCalled();
     });
 
+    it('redirects back to home if searchTerm is empty', () => {
+      // @ts-ignore: mocked events throw type errors
+      wrapper.instance().handleValueSubmit(submitMockEvent);
+      expect(props.history.push).toHaveBeenCalledWith('/');
+    });
+
     it('submits with correct props if isFormValid()', () => {
+      const { props, wrapper } = setup({ searchTerm: 'testTerm' });
       // @ts-ignore: mocked events throw type errors
       wrapper.instance().handleValueSubmit(submitMockEvent);
-      expect(props.history.push).toHaveBeenCalledWith(`/search?searchTerm=${wrapper.state().searchTerm}&selectedTab=table&pageIndex=0`);
+      expect(props.history.push).toHaveBeenCalledWith(`/search?searchTerm=${wrapper.state().searchTerm}`);
     });
 
     it('does not submit if !isFormValid()', () => {
@@ -118,11 +125,11 @@ describe('SearchBar', () => {
     describe('if searchTerm has more than one category', () => {
       let wrapper;
       beforeAll(() => {
-        wrapper = setup({ searchTerm: 'tag:tag1 tag:tag2' }).wrapper;
+        wrapper = setup().wrapper;
       })
 
       it('returns false', () => {
-        expect(wrapper.instance().isFormValid()).toEqual(false);
+        expect(wrapper.instance().isFormValid('tag:tag1 tag:tag2')).toEqual(false);
       });
 
       it('sets state.subText correctly', () => {
@@ -141,7 +148,7 @@ describe('SearchBar', () => {
       })
 
       it('returns false', () => {
-        expect(wrapper.instance().isFormValid()).toEqual(false);
+        expect(wrapper.instance().isFormValid('tag : tag1')).toEqual(false);
       });
 
       it('sets state.subText correctly', () => {
@@ -156,11 +163,11 @@ describe('SearchBar', () => {
     describe('if searchTerm has correct syntax', () => {
       let wrapper;
       beforeAll(() => {
-        wrapper = setup({ searchTerm: 'tag:tag1' }).wrapper;
+        wrapper = setup().wrapper;
       })
 
       it('returns true', () => {
-        expect(wrapper.instance().isFormValid()).toEqual(true);
+        expect(wrapper.instance().isFormValid('tag:tag1')).toEqual(true);
       });
 
       it('sets state.subText correctly', () => {