• Ryan Lieu's avatar
    Amundsen Notifications Without Preferences (#273) · 523826c0
    Ryan Lieu authored
    * Initial start to notifications API (#215)
    
    * initial start to notifications API
    
    * fixing some styling
    
    * fixed lint errors
    
    * update types
    
    * added tests
    
    * linter, moved notification types
    
    * addressed comments regarding imports/enum naming
    
    * fixed alphabetical order
    
    * Notifs post email functionality (#222)
    
    * initial start to notifications API
    
    * fixing some styling
    
    * fixed lint errors
    
    * update types
    
    * added tests
    
    * linter, moved notification types
    
    * added template support
    
    * made changes to reflect private changes
    
    * added helper function
    
    * fixed lint issue
    
    * addressed comments, added some type checking and cleaned up comments
    
    * testing removing test
    
    * fixed linter
    
    * fixed lint
    
    * fixed linting issues
    
    * skip type checking
    
    * fixed lint
    
    * fixed typing on get request args
    
    * removed typing for get request to fix lint issues
    
    * fixed linter again
    
    * re added test
    
    * raise exception inside of getmailclient
    
    * added exceptions
    
    * addressed comments
    
    * whitespace issue
    
    * removed calls to get_query_param
    
    * fixed syntax error
    
    * Send notification when adding/removing owner from table (#237)
    
    * basic e2e functionality for adding/removing
    
    * send_notification refactor
    
    * fix lint errors
    
    * blank line lint error
    
    * fixed syntax issue
    
    * arg typing
    
    * addressed comments, fixed code style
    
    * Prevent Self-Notifications (#243)
    
    * Prevent user from notifying themselves
    
    * removed exception
    
    * added owner check to send_notification
    
    * Fixed return for no recipients (#244)
    
    * fixed return for no recipients
    
    * fixed linter issue
    
    * Request notifications component (#238)
    
    * init of request form
    
    * basic request component
    
    * getting basic functionality in
    
    * clearing out css
    
    * removed z-index fixes and add constants
    
    * fixed string casting
    
    * added redux-saga calls
    
    * removed reset request notification
    
    * fixed tests
    
    * addressed comments, added basic test, added redux state management for opening/closing component
    
    * added tests, just need to add render test
    
    * cleaned up component tests:
    
    * addressed html/css comments
    
    * removed unecessary styling
    
    * removed collapsed class
    
    * cleaned up render method
    
    * fixed test
    
    * Open request component (#254)
    
    * added button to open up request component
    
    * removed tabledetail changes
    
    * className styling
    
    * fixed text-decoration
    
    * added tests, changed naming for OpenRequest
    
    * styling formatting
    
    * Add, Request, and Remove Email Copy (#257)
    
    * init for fixing email copy for request, add, and remove
    
    * removed print statement
    
    * fixed python unit test
    
    * fixed linter issues
    
    * addressed comments, fixed linter issues
    
    * added notification unit test
    
    * fixed test positional arg
    
    * fix test
    
    * Add notification action logging (#258)
    
    * init of adding action logging
    
    * changed location of action logging
    
    * fixed linter errors
    
    * fixed comment
    
    * addressed comments
    
    * remove request test call (#259)
    
    * hide request if description already exists (#269)
    
    * fixed open request button, request form styling (#267)
    
    * Added request dropdown component (#262)
    
    * init
    
    * made fixes
    
    * cleaned up code
    
    * fixed color issues
    
    * fixed import order
    
    * fixed styling, changed ducks/sagas
    
    * User dropdown (#263)
    
    * init
    
    * fixed sty;es
    
    * fixed test issue
    
    * fixed test
    
    * added tests, addressed comments
    
    * Request Metadata Component Tests (#270)
    
    * added tests + readonly field to stop errors
    
    * fixed tslint
    
    * addressed comments, added header tests
    
    * Request form navigation fix, dropdown fix (#272)
    
    * Request form navigation fix, dropdown fix
    
    * added test
    
    * added unique id to dropdown
    
    * Creates User Preferences page with no functionality (#266)
    
    * init
    
    * added event handlers
    
    * removed test file
    
    * added constants
    
    * addressed comments
    
    * fixed test, removed all links to page
    
    * updated test
    
    * fixed call to onclick
    
    * removed preferences page
    
    * Python cleanup + tests (#277)
    
    * Python cleanup + tests
    
    * More tests + revert some unecessary changes
    
    * Bring dropdown UI closer to design (#278)
    
    * Rename OpenRequestDescription for clarity + code cleanup + test additions (#279)
    
    * Notifications ducks cleanup + tests (#280)
    
    * Notifications ducks cleanup + tests
    
    * Fix issues
    
    * Fix template for edge case of empty form (#281)
    
    * Temporary debugging code, will revert
    
    * Temporary debugging code, will revert
    
    * Implement notification form confirmation (#289)
    
    * Preserve compatibility in base_mail_client (#290)
    
    * Notifications Configs + Doc (#291)
    
    * Add notification config
    
    * Code cleanup
    
    * More cleanup + add a test
    
    * Add some doc for how to enable features
    
    * Add config utils test + fix type error
    
    * Relative URLs to child configuration docs (#294)
    
    * Relative URLs to child configuration docs
    
    Relative URLs to docs in the same folder should do. They work for any branch, local copies of the docs - and should work better if we ever (or whenever :-) we get to having e.g a Sphinx generated site.
    
    * Update application_config.md
    
    Relative doc link
    
    * Update flask_config.md
    
    Relative doc link
    
    * Update flask_config.md
    
    Relative doc link
    
    * Remove temporary debugging code
    
    * Improve behavior of notification sending for owner editing (#296)
    
    * Initial Implementation: Notification only on success
    
    * Cleanup + tests: Notification only on success
    
    * Cleanup: Remove test code to trigger failure
    
    * Cleanup: Lint fix
    
    * Workaround for not notifying teams or alumni
    
    * Cleanup: Remove import mistake
    
    * Utilize NotificationType enums instead of hardcoded string
    
    * Remove use of render_template
    
    * More minor cleanups
    
    * Address some feedback
    
    * Cleanup
    
    * More cleanup
    523826c0
exceptions.py 123 Bytes