Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
A
amundsen_dev
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Surendar Reddy Mangannagari
amundsen_dev
Commits
0e262bb2
Unverified
Commit
0e262bb2
authored
Sep 10, 2019
by
Tamika Tannis
Committed by
GitHub
Sep 10, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove render_template for feedback email (#293)
* Remove render_template for feedback email * Fix html markup
parent
3eaaf377
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
13 deletions
+3
-13
v0.py
amundsen_application/api/mail/v0.py
+3
-3
email.html
amundsen_application/static/templates/email.html
+0
-10
email.html
amundsen_application/tests/templates/email.html
+0
-0
No files found.
amundsen_application/api/mail/v0.py
View file @
0e262bb2
...
...
@@ -2,7 +2,7 @@ import logging
from
http
import
HTTPStatus
from
flask
import
Response
,
jsonify
,
make_response
,
re
nder_template
,
re
quest
from
flask
import
Response
,
jsonify
,
make_response
,
request
from
flask
import
current_app
as
app
from
flask.blueprints
import
Blueprint
...
...
@@ -25,8 +25,8 @@ def feedback() -> Response:
try
:
data
=
request
.
form
.
to_dict
()
text_content
=
'
\r\n
'
.
join
(
'{}:
\r\n
{}
\r\n
'
.
format
(
k
ey
,
val
)
for
key
,
val
in
data
.
items
())
html_content
=
render_template
(
'email.html'
,
form_data
=
data
)
text_content
=
'
\r\n
'
.
join
(
'{}:
\r\n
{}
\r\n
'
.
format
(
k
,
v
)
for
k
,
v
in
data
.
items
())
html_content
=
''
.
join
(
'<div><strong>{}:</strong><br/>{}</div><br/>'
.
format
(
k
,
v
)
for
k
,
v
in
data
.
items
()
)
# action logging
feedback_type
=
data
.
get
(
'feedback-type'
)
...
...
amundsen_application/static/templates/email.html
deleted
100644 → 0
View file @
3eaaf377
<!doctype html>
{% for key, value in form_data.items() %}
<div>
<strong>
{{ key }}:
</strong>
<br/>
{{ value }}
</div>
<br/>
{% endfor %}
amundsen_application/tests/templates/email.html
deleted
100644 → 0
View file @
3eaaf377
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment