Unverified Commit 5068b3e0 authored by Tamika Tannis's avatar Tamika Tannis Committed by GitHub

fix: Remove randomized css widths (#635)

* Remove css contenthash due to no effect if using
Signed-off-by: 's avatarTamika Tannis <ttannis@lyft.com>

* Remove randomized widths
Signed-off-by: 's avatarTamika Tannis <ttannis@lyft.com>

* Cleanup
Signed-off-by: 's avatarTamika Tannis <ttannis@lyft.com>
parent c9e128a1
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
$shimmer-loader-items: 1, 2, 3, 4, 5; $shimmer-loader-items: 1, 2, 3, 4, 5;
$shimmer-loader-row-height: 16px; $shimmer-loader-row-height: 16px;
$shimmer-loader-row-min-width: 90; $shimmer-loader-row-min-width: 90;
$shimmer-loader-row-max-width: 230; $shimmer-loader-row-width: 160;
$card-height: 180px; $card-height: 180px;
$card-header-height: 60px; $card-header-height: 60px;
...@@ -86,11 +86,7 @@ $card-copy-max-lines: 3; ...@@ -86,11 +86,7 @@ $card-copy-max-lines: 3;
@each $line in $shimmer-loader-items { @each $line in $shimmer-loader-items {
.shimmer-row-line--#{$line} { .shimmer-row-line--#{$line} {
width: ( width: $shimmer-loader-row-width + px;
random($shimmer-loader-row-max-width - $shimmer-loader-row-min-width) +
$shimmer-loader-row-min-width
) +
px;
} }
} }
......
...@@ -37,6 +37,6 @@ $shimmer-loader-border-size: 1px; ...@@ -37,6 +37,6 @@ $shimmer-loader-border-size: 1px;
@each $line in $shimmer-loader-lines { @each $line in $shimmer-loader-lines {
.shimmer-resource-line--#{$line} { .shimmer-resource-line--#{$line} {
width: percentage(random(100) / 100); width: 75%;
} }
} }
...@@ -5,23 +5,12 @@ ...@@ -5,23 +5,12 @@
$shimmer-loader-tag-height: 36px; $shimmer-loader-tag-height: 36px;
$shimmer-loader-items: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14; $shimmer-loader-items: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14;
$shimmer-loader-tag-max-width: 130; $shimmer-loader-tag-width: 90;
$shimmer-loader-tag-min-width: 50;
.shimmer-tag-loader-item { .shimmer-tag-loader-item {
margin: 0 $spacer-1 $spacer-1 0; margin: 0 $spacer-1 $spacer-1 0;
height: $shimmer-loader-tag-height; height: $shimmer-loader-tag-height;
width: $shimmer-loader-tag-min-width + px; width: $shimmer-loader-tag-width + px;
border-radius: $tag-border-radius; border-radius: $tag-border-radius;
display: inline-block; display: inline-block;
} }
@each $item in $shimmer-loader-items {
.shimmer-tag-loader-item--#{$item} {
width: (
random($shimmer-loader-tag-max-width - $shimmer-loader-tag-min-width) +
$shimmer-loader-tag-min-width
) +
px;
}
}
...@@ -135,7 +135,7 @@ $shimmer-loader-lines: 1, 2, 3, 4, 5, 6; ...@@ -135,7 +135,7 @@ $shimmer-loader-lines: 1, 2, 3, 4, 5, 6;
@each $line in $shimmer-loader-lines { @each $line in $shimmer-loader-lines {
.shimmer-line--#{$line} { .shimmer-line--#{$line} {
width: percentage(random(100) / 100); width: 75%;
} }
} }
} }
...@@ -90,7 +90,7 @@ $shimmer-loader-lines: 1, 2; ...@@ -90,7 +90,7 @@ $shimmer-loader-lines: 1, 2;
@each $line in $shimmer-loader-lines { @each $line in $shimmer-loader-lines {
.shimmer-issues-line--#{$line} { .shimmer-issues-line--#{$line} {
width: percentage(random(100) / 100); width: 75%;
} }
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment