Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
A
amundsen_dev
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Surendar Reddy Mangannagari
amundsen_dev
Commits
64883365
Unverified
Commit
64883365
authored
May 14, 2020
by
Tamika Tannis
Committed by
GitHub
May 14, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unused constructors (#448)
parent
821f393c
Changes
37
Hide whitespace changes
Inline
Side-by-side
Showing
37 changed files
with
5 additions
and
153 deletions
+5
-153
index.tsx
...plication/static/js/components/AnnouncementPage/index.tsx
+0
-4
index.tsx
...on/static/js/components/DashboardPage/ChartList/index.tsx
+0
-4
index.tsx
...on/static/js/components/DashboardPage/QueryList/index.tsx
+0
-4
index.tsx
...nts/Feedback/FeedbackForm/BugReportFeedbackForm/index.tsx
+0
-4
index.tsx
...onents/Feedback/FeedbackForm/RatingFeedbackForm/index.tsx
+0
-4
index.tsx
...nents/Feedback/FeedbackForm/RequestFeedbackForm/index.tsx
+0
-4
index.tsx
...tion/static/js/components/Feedback/FeedbackForm/index.tsx
+0
-4
index.tsx
amundsen_application/static/js/components/Footer/index.tsx
+0
-4
index.tsx
amundsen_application/static/js/components/HomePage/index.tsx
+0
-4
index.tsx
amundsen_application/static/js/components/NavBar/index.tsx
+0
-4
index.tsx
...c/js/components/PreferencesPage/PreferenceGroup/index.tsx
+5
-9
index.tsx
...tatic/js/components/SearchPage/ResourceSelector/index.tsx
+0
-4
index.tsx
...mponents/SearchPage/SearchFilter/CheckBoxFilter/index.tsx
+0
-4
index.tsx
...omponents/SearchPage/SearchFilter/FilterSection/index.tsx
+0
-4
index.tsx
...on/static/js/components/SearchPage/SearchFilter/index.tsx
+0
-4
index.tsx
...sen_application/static/js/components/SearchPage/index.tsx
+0
-4
index.tsx
...on/static/js/components/TableDetail/ColumnStats/index.tsx
+0
-4
index.tsx
.../static/js/components/TableDetail/ExploreButton/index.tsx
+0
-4
index.tsx
...s/components/TableDetail/RequestDescriptionText/index.tsx
+0
-4
index.tsx
...c/js/components/TableDetail/RequestMetadataForm/index.tsx
+0
-4
index.tsx
...on/static/js/components/TableDetail/TableIssues/index.tsx
+0
-4
index.tsx
...static/js/components/TableDetail/WatermarkLabel/index.tsx
+0
-4
index.tsx
...en_application/static/js/components/TableDetail/index.tsx
+0
-4
index.tsx
...n_application/static/js/components/Tags/TagInfo/index.tsx
+0
-4
index.tsx
...atic/js/components/common/Bookmark/BookmarkIcon/index.tsx
+0
-4
index.tsx
...tatic/js/components/common/Bookmark/MyBookmarks/index.tsx
+0
-4
index.tsx
...ation/static/js/components/common/PopularTables/index.tsx
+0
-4
index.tsx
...plication/static/js/components/common/Preloader/index.tsx
+0
-4
index.tsx
...nents/common/ResourceListItem/DashboardListItem/index.tsx
+0
-4
index.tsx
...omponents/common/ResourceListItem/TableListItem/index.tsx
+0
-4
index.tsx
...components/common/ResourceListItem/UserListItem/index.tsx
+0
-4
index.tsx
...on/static/js/components/common/ResourceListItem/index.tsx
+0
-4
index.tsx
...on/SearchBar/InlineSearchResults/ResultItemList/index.tsx
+0
-4
index.tsx
...r/InlineSearchResults/SearchItemList/SearchItem/index.tsx
+0
-4
index.tsx
...on/SearchBar/InlineSearchResults/SearchItemList/index.tsx
+0
-4
index.tsx
...components/common/SearchBar/InlineSearchResults/index.tsx
+0
-4
index.tsx
...pplication/static/js/components/common/TagsList/index.tsx
+0
-4
No files found.
amundsen_application/static/js/components/AnnouncementPage/index.tsx
View file @
64883365
...
...
@@ -25,10 +25,6 @@ export interface DispatchFromProps {
export
type
AnnouncementPageProps
=
StateFromProps
&
DispatchFromProps
;
export
class
AnnouncementPage
extends
React
.
Component
<
AnnouncementPageProps
>
{
constructor
(
props
)
{
super
(
props
);
}
componentDidMount
()
{
this
.
props
.
announcementsGet
();
}
...
...
amundsen_application/static/js/components/DashboardPage/ChartList/index.tsx
View file @
64883365
...
...
@@ -7,10 +7,6 @@ export interface ChartListProps {
}
class
ChartList
extends
React
.
Component
<
ChartListProps
>
{
constructor
(
props
)
{
super
(
props
);
}
render
()
{
const
charts
=
this
.
props
.
charts
;
if
(
charts
.
length
===
0
)
{
...
...
amundsen_application/static/js/components/DashboardPage/QueryList/index.tsx
View file @
64883365
...
...
@@ -7,10 +7,6 @@ export interface QueryListProps {
}
class
QueryList
extends
React
.
Component
<
QueryListProps
>
{
constructor
(
props
)
{
super
(
props
);
}
render
()
{
const
queries
=
this
.
props
.
queries
;
if
(
queries
.
length
===
0
)
{
...
...
amundsen_application/static/js/components/Feedback/FeedbackForm/BugReportFeedbackForm/index.tsx
View file @
64883365
...
...
@@ -18,10 +18,6 @@ import {
}
from
'../../constants'
;
export
class
BugReportFeedbackForm
extends
AbstractFeedbackForm
{
constructor
(
props
)
{
super
(
props
);
}
renderCustom
()
{
return
(
<
form
id=
{
AbstractFeedbackForm
.
FORM_ID
}
onSubmit=
{
this
.
submitForm
}
>
...
...
amundsen_application/static/js/components/Feedback/FeedbackForm/RatingFeedbackForm/index.tsx
View file @
64883365
...
...
@@ -16,10 +16,6 @@ import {
}
from
'../../constants'
;
export
class
RatingFeedbackForm
extends
AbstractFeedbackForm
{
constructor
(
props
)
{
super
(
props
);
}
renderCustom
()
{
const
ratings
=
[
1
,
2
,
3
,
4
,
5
,
6
,
7
,
8
,
9
,
10
];
const
radioButtonSet
=
ratings
.
map
(
rating
=>
(
...
...
amundsen_application/static/js/components/Feedback/FeedbackForm/RequestFeedbackForm/index.tsx
View file @
64883365
...
...
@@ -18,10 +18,6 @@ import {
}
from
'../../constants'
;
export
class
RequestFeedbackForm
extends
AbstractFeedbackForm
{
constructor
(
props
)
{
super
(
props
);
}
renderCustom
()
{
return
(
<
form
id=
{
AbstractFeedbackForm
.
FORM_ID
}
onSubmit=
{
this
.
submitForm
}
>
...
...
amundsen_application/static/js/components/Feedback/FeedbackForm/index.tsx
View file @
64883365
...
...
@@ -28,10 +28,6 @@ abstract class AbstractFeedbackForm extends React.Component<FeedbackFormProps> {
static
FORM_ID
=
"feedback-form"
;
protected
constructor
(
props
)
{
super
(
props
);
}
submitForm
=
(
event
)
=>
{
event
.
preventDefault
();
const
form
=
document
.
getElementById
(
AbstractFeedbackForm
.
FORM_ID
)
as
HTMLFormElement
;
...
...
amundsen_application/static/js/components/Footer/index.tsx
View file @
64883365
...
...
@@ -21,10 +21,6 @@ interface DispatchFromProps {
export
type
FooterProps
=
StateFromProps
&
DispatchFromProps
;
export
class
Footer
extends
React
.
Component
<
FooterProps
>
{
constructor
(
props
)
{
super
(
props
);
}
componentDidMount
()
{
this
.
props
.
getLastIndexed
();
}
...
...
amundsen_application/static/js/components/HomePage/index.tsx
View file @
64883365
...
...
@@ -23,10 +23,6 @@ export interface DispatchFromProps {
export
type
HomePageProps
=
DispatchFromProps
&
RouteComponentProps
<
any
>
;
export
class
HomePage
extends
React
.
Component
<
HomePageProps
>
{
constructor
(
props
)
{
super
(
props
);
}
componentDidMount
()
{
this
.
props
.
searchReset
();
}
...
...
amundsen_application/static/js/components/NavBar/index.tsx
View file @
64883365
...
...
@@ -27,10 +27,6 @@ interface StateFromProps {
export
type
NavBarProps
=
StateFromProps
&
RouteComponentProps
<
{}
>
;
export
class
NavBar
extends
React
.
Component
<
NavBarProps
>
{
constructor
(
props
)
{
super
(
props
);
}
generateNavLinks
(
navLinks
:
LinkConfig
[])
{
return
navLinks
.
map
((
link
,
index
)
=>
{
if
(
link
.
use_router
)
{
...
...
amundsen_application/static/js/components/PreferencesPage/PreferenceGroup/index.tsx
View file @
64883365
...
...
@@ -11,15 +11,11 @@ export type PreferenceGroupProps = {
}
export
class
PreferenceGroup
extends
React
.
Component
<
PreferenceGroupProps
>
{
public
static
defaultProps
:
Partial
<
PreferenceGroupProps
>
=
{
selected
:
false
,
title
:
''
,
subtitle
:
''
,
};
constructor
(
props
)
{
super
(
props
);
}
public
static
defaultProps
:
Partial
<
PreferenceGroupProps
>
=
{
selected
:
false
,
title
:
''
,
subtitle
:
''
,
};
onClick
=
()
=>
{
this
.
props
.
onClick
(
this
.
props
.
preferenceValue
)
...
...
amundsen_application/static/js/components/SearchPage/ResourceSelector/index.tsx
View file @
64883365
...
...
@@ -35,10 +35,6 @@ interface ResourceOptionConfig {
}
export
class
ResourceSelector
extends
React
.
Component
<
ResourceSelectorProps
>
{
constructor
(
props
)
{
super
(
props
);
}
onChange
=
(
event
)
=>
{
this
.
props
.
setResource
(
event
.
target
.
value
);
};
...
...
amundsen_application/static/js/components/SearchPage/SearchFilter/CheckBoxFilter/index.tsx
View file @
64883365
...
...
@@ -28,10 +28,6 @@ interface DispatchFromProps {
export
type
CheckBoxFilterProps
=
OwnProps
&
DispatchFromProps
&
StateFromProps
;
export
class
CheckBoxFilter
extends
React
.
Component
<
CheckBoxFilterProps
>
{
constructor
(
props
)
{
super
(
props
);
}
createCheckBoxItem
=
(
categoryId
:
string
,
key
:
string
,
item
:
CheckboxFilterProperties
)
=>
{
const
{
label
,
value
}
=
item
;
return
(
...
...
amundsen_application/static/js/components/SearchPage/SearchFilter/FilterSection/index.tsx
View file @
64883365
...
...
@@ -34,10 +34,6 @@ export interface DispatchFromProps {
export
type
FilterSectionProps
=
OwnProps
&
DispatchFromProps
&
StateFromProps
;
export
class
FilterSection
extends
React
.
Component
<
FilterSectionProps
>
{
constructor
(
props
)
{
super
(
props
);
}
onClearFilter
=
()
=>
{
this
.
props
.
clearFilter
(
this
.
props
.
categoryId
);
}
...
...
amundsen_application/static/js/components/SearchPage/SearchFilter/index.tsx
View file @
64883365
...
...
@@ -30,10 +30,6 @@ export interface StateFromProps {
export
type
SearchFilterProps
=
StateFromProps
;
export
class
SearchFilter
extends
React
.
Component
<
SearchFilterProps
>
{
constructor
(
props
)
{
super
(
props
);
}
createFilterSection
=
(
key
:
string
,
section
:
FilterSection
|
CheckboxFilterSection
)
=>
{
const
{
categoryId
,
helpText
,
title
,
type
}
=
section
;
const
options
=
(
section
as
CheckboxFilterSection
).
options
?
(
section
as
CheckboxFilterSection
).
options
:
undefined
;
...
...
amundsen_application/static/js/components/SearchPage/index.tsx
View file @
64883365
...
...
@@ -60,10 +60,6 @@ export type SearchPageProps = StateFromProps & DispatchFromProps & RouteComponen
export
class
SearchPage
extends
React
.
Component
<
SearchPageProps
>
{
public
static
defaultProps
:
Partial
<
SearchPageProps
>
=
{};
constructor
(
props
)
{
super
(
props
);
}
componentDidMount
()
{
this
.
props
.
urlDidUpdate
(
this
.
props
.
location
.
search
);
}
...
...
amundsen_application/static/js/components/TableDetail/ColumnStats/index.tsx
View file @
64883365
...
...
@@ -10,10 +10,6 @@ export interface ColumnStatsProps {
}
export
class
ColumnStats
extends
React
.
Component
<
ColumnStatsProps
>
{
constructor
(
props
)
{
super
(
props
);
}
getStatsInfoText
=
(
startEpoch
:
number
,
endEpoch
:
number
)
=>
{
const
startDate
=
startEpoch
?
formatDate
({
epochTimestamp
:
startEpoch
})
:
null
;
const
endDate
=
endEpoch
?
formatDate
({
epochTimestamp
:
endEpoch
})
:
null
;
...
...
amundsen_application/static/js/components/TableDetail/ExploreButton/index.tsx
View file @
64883365
...
...
@@ -9,10 +9,6 @@ export interface ExploreButtonProps {
}
class
ExploreButton
extends
React
.
Component
<
ExploreButtonProps
>
{
constructor
(
props
)
{
super
(
props
);
}
render
()
{
const
url
=
generateExploreUrl
(
this
.
props
.
tableData
);
if
(
!
url
||
!
exploreEnabled
())
{
...
...
amundsen_application/static/js/components/TableDetail/RequestDescriptionText/index.tsx
View file @
64883365
...
...
@@ -21,10 +21,6 @@ interface RequestDescriptionTextState {}
export
class
RequestDescriptionText
extends
React
.
Component
<
RequestDescriptionTextProps
,
RequestDescriptionTextState
>
{
public
static
defaultProps
:
Partial
<
RequestDescriptionTextProps
>
=
{};
constructor
(
props
)
{
super
(
props
);
}
openRequest
=
()
=>
{
this
.
props
.
openRequestDescriptionDialog
(
RequestMetadataType
.
TABLE_DESCRIPTION
);
}
...
...
amundsen_application/static/js/components/TableDetail/RequestMetadataForm/index.tsx
View file @
64883365
...
...
@@ -57,10 +57,6 @@ interface RequestMetadataState {}
export
class
RequestMetadataForm
extends
React
.
Component
<
RequestMetadataProps
,
RequestMetadataState
>
{
public
static
defaultProps
:
Partial
<
RequestMetadataProps
>
=
{};
constructor
(
props
)
{
super
(
props
);
}
componentWillUnmount
=
()
=>
{
this
.
props
.
closeRequestDescriptionDialog
();
}
...
...
amundsen_application/static/js/components/TableDetail/TableIssues/index.tsx
View file @
64883365
...
...
@@ -31,10 +31,6 @@ export interface ComponentProps {
export
type
TableIssueProps
=
StateFromProps
&
DispatchFromProps
&
ComponentProps
;
export
class
TableIssues
extends
React
.
Component
<
TableIssueProps
>
{
constructor
(
props
)
{
super
(
props
);
}
componentDidMount
()
{
this
.
props
.
getIssues
(
this
.
props
.
tableKey
);
}
...
...
amundsen_application/static/js/components/TableDetail/WatermarkLabel/index.tsx
View file @
64883365
...
...
@@ -15,10 +15,6 @@ export interface WatermarkLabelProps {
}
class
WatermarkLabel
extends
React
.
Component
<
WatermarkLabelProps
>
{
constructor
(
props
)
{
super
(
props
);
}
formatWatermarkDate
=
(
dateString
:
string
)
=>
{
return
formatDate
({
dateString
,
...
...
amundsen_application/static/js/components/TableDetail/index.tsx
View file @
64883365
...
...
@@ -66,10 +66,6 @@ class TableDetail extends React.Component<TableDetailProps & RouteComponentProps
private
key
:
string
;
private
didComponentMount
:
boolean
=
false
;
constructor
(
props
)
{
super
(
props
);
}
componentDidMount
()
{
const
{
index
,
source
}
=
getLoggingParams
(
this
.
props
.
location
.
search
);
...
...
amundsen_application/static/js/components/Tags/TagInfo/index.tsx
View file @
64883365
...
...
@@ -26,10 +26,6 @@ export class TagInfo extends React.Component<TagInfoProps> {
compact
:
true
};
constructor
(
props
)
{
super
(
props
);
}
onClick
=
(
e
)
=>
{
const
name
=
this
.
props
.
data
.
tag_name
;
logClick
(
e
,
{
...
...
amundsen_application/static/js/components/common/Bookmark/BookmarkIcon/index.tsx
View file @
64883365
...
...
@@ -33,10 +33,6 @@ export class BookmarkIcon extends React.Component<BookmarkIconProps> {
large
:
false
,
};
constructor
(
props
)
{
super
(
props
);
}
handleClick
=
(
event
:
React
.
MouseEvent
<
HTMLElement
>
)
=>
{
event
.
stopPropagation
();
event
.
preventDefault
();
...
...
amundsen_application/static/js/components/common/Bookmark/MyBookmarks/index.tsx
View file @
64883365
...
...
@@ -22,10 +22,6 @@ interface StateFromProps {
export
type
MyBookmarksProps
=
StateFromProps
;
export
class
MyBookmarks
extends
React
.
Component
<
MyBookmarksProps
>
{
constructor
(
props
)
{
super
(
props
);
}
generateTabContent
=
(
resource
:
ResourceType
)
=>
{
const
bookmarks
=
this
.
props
.
myBookmarks
[
resource
];
if
(
!
bookmarks
)
{
...
...
amundsen_application/static/js/components/common/PopularTables/index.tsx
View file @
64883365
...
...
@@ -31,10 +31,6 @@ export interface DispatchFromProps {
export
type
PopularTablesProps
=
StateFromProps
&
DispatchFromProps
;
export
class
PopularTables
extends
React
.
Component
<
PopularTablesProps
>
{
constructor
(
props
)
{
super
(
props
);
}
componentDidMount
()
{
this
.
props
.
getPopularTables
();
}
...
...
amundsen_application/static/js/components/common/Preloader/index.tsx
View file @
64883365
...
...
@@ -16,10 +16,6 @@ interface DispatchFromProps {
export
type
PreloaderProps
=
DispatchFromProps
;
export
class
Preloader
extends
React
.
Component
<
PreloaderProps
>
{
constructor
(
props
)
{
super
(
props
)
}
componentDidMount
()
{
this
.
props
.
getLoggedInUser
();
this
.
props
.
getBookmarks
();
...
...
amundsen_application/static/js/components/common/ResourceListItem/DashboardListItem/index.tsx
View file @
64883365
...
...
@@ -20,10 +20,6 @@ export interface DashboardListItemProps {
}
class
DashboardListItem
extends
React
.
Component
<
DashboardListItemProps
,
{}
>
{
constructor
(
props
)
{
super
(
props
);
}
getLink
=
()
=>
{
const
{
dashboard
,
logging
}
=
this
.
props
;
return
`/dashboard?uri=
${
dashboard
.
uri
}
&index=
${
logging
.
index
}
&source=
${
logging
.
source
}
`
;
...
...
amundsen_application/static/js/components/common/ResourceListItem/TableListItem/index.tsx
View file @
64883365
...
...
@@ -17,10 +17,6 @@ export interface TableListItemProps {
}
class
TableListItem
extends
React
.
Component
<
TableListItemProps
,
{}
>
{
constructor
(
props
)
{
super
(
props
);
}
getLink
=
()
=>
{
const
{
table
,
logging
}
=
this
.
props
;
return
`/table_detail/
${
table
.
cluster
}
/
${
table
.
database
}
/
${
table
.
schema
}
/
${
table
.
name
}
`
...
...
amundsen_application/static/js/components/common/ResourceListItem/UserListItem/index.tsx
View file @
64883365
...
...
@@ -13,10 +13,6 @@ export interface UserListItemProps {
}
class
UserListItem
extends
React
.
Component
<
UserListItemProps
,
{}
>
{
constructor
(
props
)
{
super
(
props
);
}
getLink
=
()
=>
{
const
{
user
,
logging
}
=
this
.
props
;
return
`/user/
${
user
.
user_id
}
?index=
${
logging
.
index
}
&source=
${
logging
.
source
}
`
;
...
...
amundsen_application/static/js/components/common/ResourceListItem/index.tsx
View file @
64883365
...
...
@@ -15,10 +15,6 @@ export interface ListItemProps {
}
export
default
class
ResourceListItem
extends
React
.
Component
<
ListItemProps
>
{
constructor
(
props
)
{
super
(
props
);
}
render
()
{
switch
(
this
.
props
.
item
.
type
)
{
case
ResourceType
.
dashboard
:
...
...
amundsen_application/static/js/components/common/SearchBar/InlineSearchResults/ResultItemList/index.tsx
View file @
64883365
...
...
@@ -18,10 +18,6 @@ export interface ResultItemListProps {
}
class
ResultItemList
extends
React
.
Component
<
ResultItemListProps
,
{}
>
{
constructor
(
props
)
{
super
(
props
);
}
generateFooterLinkText
=
()
=>
{
const
{
totalResults
,
title
}
=
this
.
props
;
return
`
${
RESULT_LIST_FOOTER_PREFIX
}
${
totalResults
}
${
title
}
${
RESULT_LIST_FOOTER_SUFFIX
}
`
;
...
...
amundsen_application/static/js/components/common/SearchBar/InlineSearchResults/SearchItemList/SearchItem/index.tsx
View file @
64883365
...
...
@@ -26,10 +26,6 @@ export interface OwnProps {
export
type
SearchItemProps
=
StateFromProps
&
OwnProps
;
export
class
SearchItem
extends
React
.
Component
<
SearchItemProps
,
{}
>
{
constructor
(
props
)
{
super
(
props
);
}
onViewAllResults
=
(
e
)
=>
{
logClick
(
e
);
this
.
props
.
onItemSelect
(
this
.
props
.
resourceType
,
true
);
...
...
amundsen_application/static/js/components/common/SearchBar/InlineSearchResults/SearchItemList/index.tsx
View file @
64883365
...
...
@@ -14,10 +14,6 @@ export interface SearchItemListProps {
}
class
SearchItemList
extends
React
.
Component
<
SearchItemListProps
,
{}
>
{
constructor
(
props
)
{
super
(
props
);
}
getListItemText
=
(
resourceType
:
ResourceType
):
string
=>
{
switch
(
resourceType
)
{
case
ResourceType
.
dashboard
:
...
...
amundsen_application/static/js/components/common/SearchBar/InlineSearchResults/index.tsx
View file @
64883365
...
...
@@ -39,10 +39,6 @@ export interface SuggestedResult {
}
export
class
InlineSearchResults
extends
React
.
Component
<
InlineSearchResultsProps
,
{}
>
{
constructor
(
props
)
{
super
(
props
);
}
getTitleForResource
=
(
resourceType
:
ResourceType
):
string
=>
{
switch
(
resourceType
)
{
case
ResourceType
.
dashboard
:
...
...
amundsen_application/static/js/components/common/TagsList/index.tsx
View file @
64883365
...
...
@@ -26,10 +26,6 @@ export interface DispatchFromProps {
export
type
TagsListProps
=
StateFromProps
&
DispatchFromProps
;
export
class
TagsList
extends
React
.
Component
<
TagsListProps
>
{
constructor
(
props
)
{
super
(
props
);
}
componentDidMount
()
{
this
.
props
.
getAllTags
();
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment