Unverified Commit 6e6472d7 authored by Allison Suarez Miranda's avatar Allison Suarez Miranda Committed by GitHub

fix: added Status text to last run status line for dashboard (#603)

* added Status text to Las Run status line
Signed-off-by: 's avatarAllison Suarez Miranda <asuarezmiranda@lyft.com>

* lint
Signed-off-by: 's avatarAllison Suarez Miranda <asuarezmiranda@lyft.com>

* added Status: to constants
Signed-off-by: 's avatarAllison Suarez Miranda <asuarezmiranda@lyft.com>

* lint again, pre-commit hooks not working again...
Signed-off-by: 's avatarAllison Suarez Miranda <asuarezmiranda@lyft.com>
parent d2f222ea
...@@ -7,3 +7,4 @@ export const ADD_DESC_TEXT = 'Add Description in'; ...@@ -7,3 +7,4 @@ export const ADD_DESC_TEXT = 'Add Description in';
export const EDIT_DESC_TEXT = 'Click to edit description in'; export const EDIT_DESC_TEXT = 'Click to edit description in';
export const LAST_RUN_SUCCEEDED = 'succeeded'; export const LAST_RUN_SUCCEEDED = 'succeeded';
export const STATUS_TEXT = 'Status:';
...@@ -34,6 +34,7 @@ import { ...@@ -34,6 +34,7 @@ import {
DASHBOARD_SOURCE, DASHBOARD_SOURCE,
TABLES_PER_PAGE, TABLES_PER_PAGE,
LAST_RUN_SUCCEEDED, LAST_RUN_SUCCEEDED,
STATUS_TEXT,
} from 'components/DashboardPage/constants'; } from 'components/DashboardPage/constants';
import TagInput from 'components/common/Tags/TagInput'; import TagInput from 'components/common/Tags/TagInput';
import { ResourceType } from 'interfaces'; import { ResourceType } from 'interfaces';
...@@ -304,6 +305,7 @@ export class DashboardPage extends React.Component< ...@@ -304,6 +305,7 @@ export class DashboardPage extends React.Component<
: NO_TIMESTAMP_TEXT} : NO_TIMESTAMP_TEXT}
</time> </time>
<div className="last-run-state"> <div className="last-run-state">
<span className="status">{STATUS_TEXT}</span>
<ResourceStatusMarker <ResourceStatusMarker
stateText={dashboard.last_run_state} stateText={dashboard.last_run_state}
succeeded={this.mapStatusToBoolean( succeeded={this.mapStatusToBoolean(
......
...@@ -2,6 +2,7 @@ ...@@ -2,6 +2,7 @@
// SPDX-License-Identifier: Apache-2.0 // SPDX-License-Identifier: Apache-2.0
@import 'variables'; @import 'variables';
@import 'typography-default';
.dashboard-page { .dashboard-page {
.header-section { .header-section {
...@@ -15,8 +16,12 @@ ...@@ -15,8 +16,12 @@
} }
.last-run-state { .last-run-state {
.flag { margin-top: $spacer-1;
margin: $spacer-1 0 0 0; .status {
@extend %text-body-w2;
display: inline-block;
vertical-align: middle;
} }
} }
......
...@@ -18,6 +18,12 @@ $icon-size: 14px; ...@@ -18,6 +18,12 @@ $icon-size: 14px;
vertical-align: middle; vertical-align: middle;
} }
.failure,
.success {
display: inline-block;
margin-left: $spacer-1;
}
.failure-icon { .failure-icon {
background-color: $icon-status-missed; background-color: $icon-status-missed;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment