Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
A
amundsen_dev
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Surendar Reddy Mangannagari
amundsen_dev
Commits
74e7bed9
Unverified
Commit
74e7bed9
authored
Jun 22, 2020
by
Tamika Tannis
Committed by
GitHub
Jun 22, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: Remove beta flag for dashboard UI (#492)
* Remove beta flag * Lint fix
parent
f5a1c32a
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
12 additions
and
30 deletions
+12
-30
_animations.scss
amundsen_application/static/css/_animations.scss
+8
-9
index.tsx
..._application/static/js/components/DashboardPage/index.tsx
+1
-3
index.tsx
...tatic/js/components/SearchPage/ResourceSelector/index.tsx
+0
-4
index.tsx
...on/SearchBar/InlineSearchResults/ResultItemList/index.tsx
+1
-7
index.tsx
...r/InlineSearchResults/SearchItemList/SearchItem/index.tsx
+0
-4
styles.scss
.../js/components/common/ShimmeringTagListLoader/styles.scss
+2
-3
No files found.
amundsen_application/static/css/_animations.scss
View file @
74e7bed9
...
...
@@ -15,15 +15,14 @@ $loading-curve: cubic-bezier(0.45, 0, 0.15, 1);
.is-shimmer-animated
{
animation
:
$loading-duration
shimmer
$loading-curve
infinite
;
background-image
:
linear-gradient
(
to
right
,
$gray10
0%
,
$gray10
33%
,
$gray5
50%
,
$gray10
67%
,
$gray10
100%
);
background-image
:
linear-gradient
(
to
right
,
$gray10
0%
,
$gray10
33%
,
$gray5
50%
,
$gray10
67%
,
$gray10
100%
);
background-repeat
:
no-repeat
;
background-size
:
300%
100%
;
}
amundsen_application/static/js/components/DashboardPage/index.tsx
View file @
74e7bed9
...
...
@@ -174,9 +174,7 @@ export class DashboardPage extends React.Component<
resourceType=
{
ResourceType
.
dashboard
}
/>
<
div
className=
"body-2"
>
Dashboard
<
Flag
text=
"beta"
labelStyle=
"default"
/>
in
Dashboard in
<
a
id=
"dashboard-group-link"
onClick=
{
logClick
}
...
...
amundsen_application/static/js/components/SearchPage/ResourceSelector/index.tsx
View file @
74e7bed9
...
...
@@ -2,7 +2,6 @@ import * as React from 'react';
import
{
bindActionCreators
}
from
'redux'
;
import
{
connect
}
from
'react-redux'
;
import
Flag
from
'components/common/Flag'
;
import
{
DASHBOARD_RESOURCE_TITLE
,
TABLE_RESOURCE_TITLE
,
...
...
@@ -57,9 +56,6 @@ export class ResourceSelector extends React.Component<ResourceSelectorProps> {
onChange=
{
this
.
onChange
}
/>
<
span
className=
"subtitle-2"
>
{
option
.
label
}
</
span
>
{
option
.
type
===
ResourceType
.
dashboard
&&
(
<
Flag
text=
"beta"
labelStyle=
"default"
/>
)
}
<
span
className=
"body-secondary-3 pull-right"
>
{
option
.
count
}
</
span
>
</
label
>
</
div
>
...
...
amundsen_application/static/js/components/common/SearchBar/InlineSearchResults/ResultItemList/index.tsx
View file @
74e7bed9
...
...
@@ -2,7 +2,6 @@ import * as React from 'react';
import
{
logClick
}
from
'ducks/utilMethods'
;
import
{
ResourceType
}
from
'interfaces'
;
import
Flag
from
'components/common/Flag'
;
import
{
SuggestedResult
}
from
'..'
;
import
ResultItem
from
'./ResultItem'
;
...
...
@@ -60,12 +59,7 @@ class ResultItemList extends React.Component<ResultItemListProps, {}> {
const
{
resourceType
,
suggestedResults
,
title
}
=
this
.
props
;
return
(
<>
<
h3
className=
"section-title title-3"
>
{
title
}
{
resourceType
===
ResourceType
.
dashboard
&&
(
<
Flag
text=
"beta"
labelStyle=
"default"
/>
)
}
</
h3
>
<
h3
className=
"section-title title-3"
>
{
title
}
</
h3
>
<
ul
className=
"list-group"
>
{
this
.
renderResultItems
(
suggestedResults
)
}
</
ul
>
...
...
amundsen_application/static/js/components/common/SearchBar/InlineSearchResults/SearchItemList/SearchItem/index.tsx
View file @
74e7bed9
...
...
@@ -4,7 +4,6 @@ import { connect } from 'react-redux';
import
{
logClick
}
from
'ducks/utilMethods'
;
import
{
ResourceType
}
from
'interfaces'
;
import
Flag
from
'components/common/Flag'
;
import
LoadingSpinner
from
'components/common/LoadingSpinner'
;
import
{
GlobalState
}
from
'ducks/rootReducer'
;
...
...
@@ -60,9 +59,6 @@ export class SearchItem extends React.Component<SearchItemProps, {}> {
<
div
className=
"title-2 search-item-info"
>
<
div
className=
"search-term"
>
{
`${searchTerm}\u00a0`
}
</
div
>
<
div
className=
"search-item-text"
>
{
listItemText
}
</
div
>
{
resourceType
===
ResourceType
.
dashboard
&&
(
<
Flag
text=
"beta"
labelStyle=
"default"
/>
)
}
</
div
>
{
this
.
renderIndicator
()
}
</
a
>
...
...
amundsen_application/static/js/components/common/ShimmeringTagListLoader/styles.scss
View file @
74e7bed9
...
...
@@ -18,10 +18,9 @@ $shimmer-loader-tag-min-width: 50;
@each
$item
in
$shimmer-loader-items
{
.shimmer-tag-loader-item--
#{
$item
}
{
width
:
(
width
:
(
random
(
$shimmer-loader-tag-max-width
-
$shimmer-loader-tag-min-width
)
+
$shimmer-loader-tag-min-width
$shimmer-loader-tag-min-width
)
+
px
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment