Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
A
amundsen_dev
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Surendar Reddy Mangannagari
amundsen_dev
Commits
b824579a
Unverified
Commit
b824579a
authored
May 21, 2019
by
Ryan Lieu
Committed by
GitHub
May 21, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Reverse frequent user order positioning (#167)
parent
899c2aff
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
13 additions
and
14 deletions
+13
-14
_avatars.scss
amundsen_application/static/css/_avatars.scss
+7
-0
styles.scss
amundsen_application/static/css/styles.scss
+1
-0
styles.scss
amundsen_application/static/js/components/NavBar/styles.scss
+0
-4
index.tsx
...en_application/static/js/components/TableDetail/index.tsx
+5
-6
styles.scss
...ation/static/js/components/common/AvatarLabel/styles.scss
+0
-4
No files found.
amundsen_application/static/css/_avatars.scss
0 → 100644
View file @
b824579a
.sb-avatar
>
div
{
border
:
1px
solid
white
;
}
.sb-avatar
>
img
{
margin
:
0px
;
}
amundsen_application/static/css/styles.scss
View file @
b824579a
@import
'bootstrap-custom'
;
@import
'avatars'
;
@import
'buttons'
;
@import
'fonts'
;
@import
'icons'
;
...
...
amundsen_application/static/js/components/NavBar/styles.scss
View file @
b824579a
...
...
@@ -48,10 +48,6 @@
box-shadow
:
0px
0px
10px
-1px
rgba
(
0
,
0
,
0
,
.76
);
}
.sb-avatar
>
div
{
border
:
1px
solid
white
;
}
.logo-icon
{
max-height
:
32px
;
max-width
:
144px
;
...
...
amundsen_application/static/js/components/TableDetail/index.tsx
View file @
b824579a
...
...
@@ -124,12 +124,11 @@ export class TableDetail extends React.Component<TableDetailProps & RouteCompone
})
};
getAvatarForUser
(
fullName
,
profileUrl
)
{
getAvatarForUser
(
fullName
,
profileUrl
,
zIndex
)
{
const
popoverHoverFocus
=
(
<
Popover
id=
"popover-trigger-hover-focus"
>
{
fullName
}
</
Popover
>);
if
(
profileUrl
.
length
!==
0
)
{
return
(
<
OverlayTrigger
key=
{
fullName
}
trigger=
{
[
'hover'
,
'focus'
]
}
placement=
"top"
overlay=
{
popoverHoverFocus
}
>
...
...
@@ -137,7 +136,7 @@ export class TableDetail extends React.Component<TableDetailProps & RouteCompone
style=
{
{
display
:
'inline-block'
,
marginLeft
:
'-5px'
,
backgroundColor
:
'white'
,
borderRadius
:
'90%'
}
}
onClick=
{
this
.
frequentUserOnClick
}
>
<
Avatar
name=
{
fullName
}
size=
{
25
}
round=
{
true
}
style=
{
{
border
:
'1px solid white'
}
}
/>
<
Avatar
name=
{
fullName
}
size=
{
25
}
round=
{
true
}
style=
{
{
zIndex
,
position
:
'relative'
}
}
/>
</
a
>
</
OverlayTrigger
>
);
...
...
@@ -146,7 +145,7 @@ export class TableDetail extends React.Component<TableDetailProps & RouteCompone
<
OverlayTrigger
key=
{
fullName
}
trigger=
{
[
'hover'
,
'focus'
]
}
placement=
"top"
overlay=
{
popoverHoverFocus
}
>
<
div
style=
{
{
display
:
'inline-block'
,
marginLeft
:
'-5px'
,
backgroundColor
:
'white'
,
borderRadius
:
'90%'
}
}
>
<
Avatar
name=
{
fullName
}
size=
{
25
}
round=
{
true
}
style=
{
{
border
:
'1px solid whit
e'
}
}
/>
<
Avatar
name=
{
fullName
}
size=
{
25
}
round=
{
true
}
style=
{
{
zIndex
,
position
:
'relativ
e'
}
}
/>
</
div
>
</
OverlayTrigger
>
);
...
...
@@ -223,12 +222,12 @@ export class TableDetail extends React.Component<TableDetailProps & RouteCompone
// "Frequent Users" section
const
readerSectionRenderer
=
()
=>
{
return
(
data
.
table_readers
&&
data
.
table_readers
.
length
>
0
)
?
data
.
table_readers
.
map
((
entry
)
=>
{
data
.
table_readers
.
map
((
entry
,
index
)
=>
{
const
fullName
=
entry
.
reader
.
display_name
;
const
profileUrl
=
entry
.
reader
.
profile_url
;
return
(
this
.
getAvatarForUser
(
fullName
,
profileUrl
)
this
.
getAvatarForUser
(
fullName
,
profileUrl
,
data
.
table_readers
.
length
-
index
)
);
})
:
(<
label
className=
"m-auto"
>
No frequent users exist
</
label
>);
...
...
amundsen_application/static/js/components/common/AvatarLabel/styles.scss
View file @
b824579a
...
...
@@ -19,7 +19,3 @@
font-weight
:
normal
;
min-width
:
0
;
}
.sb-avatar
>
img
{
margin
:
0px
;
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment