Fixes typeahead result icons not showing (#446)

amundsen_application/static/js/components/common/SearchBar/InlineSearchResults/ResultItemList/ResultItem/tests/index.spec.tsx → amundsen_application/static/js/components/common/SearchBar/InlineSearchResults/ResultItemList/ResultItem/index.spec.tsx

@@ -3,7 +3,7 @@ import { Link } from 'react-router-dom';
 
 import { shallow } from 'enzyme';
 
-import ResultItem, { ResultItemProps } from '../';
+import ResultItem, { ResultItemProps } from '.';
 
 describe('ResultItem', () => {
   let props: ResultItemProps;
@@ -34,7 +34,7 @@ describe('ResultItem', () => {
     });
 
     it('renders icon with correct props', () => {
-      expect(link.find('img').props().className).toEqual(`result-icon ${props.iconClass}`);
+      expect(link.find('span').props().className).toEqual(`result-icon ${props.iconClass}`);
     });
 
     describe('renders result-info', () => {

amundsen_application/static/js/components/common/SearchBar/InlineSearchResults/ResultItemList/ResultItem/index.tsx

@@ -15,7 +15,7 @@ const ResultItem: React.SFC<ResultItemProps> = ({ href, iconClass, id, onItemSel
   return (
     <li className="list-group-item">
       <Link id={id} className="result-item-link" onClick={onItemSelect} to={ href }>
-        <img className={`result-icon ${iconClass}`} />
+        <span className={`result-icon ${iconClass}`} />
 
         <div className="result-info my-auto">
           <div className="truncated">

amundsen_application/static/js/components/common/SearchBar/InlineSearchResults/styles.scss

@@ -71,7 +71,7 @@
           text-decoration: none;
 
           img.icon.icon-search,
-          img.icon.result-icon,
+          span.icon.result-icon,
           .sb-avatar {
             margin: auto 8px auto 0px;
           }